Add QoS settings for Arista-7060X6-16PE-384C-O128S2 by rick-arista · Pull Request #22431 · sonic-net/sonic-buildimage

rick-arista · 2025-04-24T01:14:43Z

Why I did it

Add QoS settings for Arista-7060X6-16PE-384C-O128S2

Work item tracking

Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld · 2025-04-24T01:14:52Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-04-24T01:15:03Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-04-24T18:03:45Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-04-24T18:03:56Z

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn · 2025-04-28T19:34:41Z

@rick-arista For T0/T1 buffer configs, please use - https://github.com/sonic-net/sonic-buildimage/pull/22336/files

I will close the other PR to avoid conflicts

kperumalbfn · 2025-04-28T19:37:40Z

...6_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/th5-a7060x6-16pe-384c.config.bcm

Could you please check this - #21892

Based on the latest response from Broadcom, sai_mmu_custom_config is required

r12f

@kperumalbfn do we need per Q settings here?

device/arista/x86_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/qos.json.j2

r12f

@kperumalbfn do we need per Q settings here?

r12f · 2025-04-29T17:52:38Z

...e/arista/x86_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/pg_profile_lookup.ini

@kperumalbfn to confirm the numbers here.

r12f · 2025-04-29T17:52:43Z

.../arista/x86_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/buffers_defaults_t0.j2

@kperumalbfn to confirm the numbers here.

@rick-arista pls use the buffer numbers from https://github.com/sonic-net/sonic-buildimage/pull/22336/files

Updated both PRs, can you confirm these are the only necessary changes?

3d9a196

885cedc

kperumalbfn · 2025-04-29T17:57:34Z

@kperumalbfn do we need per Q settings here?

Will be good for updating the weights later.

mssonicbld · 2025-04-29T23:09:16Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-04-29T23:09:28Z

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn · 2025-04-30T17:10:38Z

kperumalbfn · 2025-04-30T17:13:42Z

mssonicbld · 2025-04-30T20:09:53Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-04-30T20:10:04Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-04-30T23:05:37Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-04-30T23:05:48Z

Azure Pipelines successfully started running 1 pipeline(s).

kperumalbfn · 2025-05-02T21:55:24Z

@r12f please add to 202412

r12f · 2025-05-06T20:33:13Z

hi @rick-arista , do you mind to help pick this change to 202412? it is currently having some conflict in the PR.

kperumalbfn · 2025-05-08T00:29:24Z

@r12f 202412 PR - Azure/sonic-buildimage-msft#1081

yejianquan · 2025-07-14T02:42:45Z

Hi @rick-arista , please fix the conflict and create PR to 202505 branch

yejianquan · 2025-07-14T07:01:34Z

202505 branched out around 5/16, this commit is included when created, removing request labels.
and please ignore the conflict notification

StormLiangMS requested review from developfast, kperumalbfn and r12f April 24, 2025 04:17

kperumalbfn reviewed Apr 28, 2025

View reviewed changes

r12f reviewed Apr 29, 2025

View reviewed changes

device/arista/x86_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/qos.json.j2 Outdated Show resolved Hide resolved

r12f reviewed Apr 29, 2025

View reviewed changes

device/arista/x86_64-arista_7060x6_16pe_384c/Arista-7060X6-16PE-384C-O128S2/qos.json.j2 Outdated Show resolved Hide resolved

r12f reviewed Apr 29, 2025

View reviewed changes

rick-arista added 4 commits April 30, 2025 23:04

Add QoS settings for Arista-7060X6-16PE-384C-O128S2

a671f0c

Fix sai mmu setting

48431c2

Update buffer pool sizes

ca06348

Update buffer settings

62e89c3

rick-arista force-pushed the Arista-7060X6-16PE-384C-O128S2 branch from 59d74bc to 62e89c3 Compare April 30, 2025 23:05

kperumalbfn approved these changes May 2, 2025

View reviewed changes

kperumalbfn merged commit 5323725 into sonic-net:master May 2, 2025
19 checks passed

kperumalbfn added the Request for msft-202412 Branch label May 2, 2025

mssonicbld added the Cherry Pick Conflict_msft-202412 label May 2, 2025

r12f added Request for msft-202412 Branch and removed Request for msft-202412 Branch Cherry Pick Conflict_msft-202412 labels May 2, 2025

mssonicbld added the Cherry Pick Conflict_msft-202412 label May 2, 2025

yanmarkman mentioned this pull request May 5, 2025

Bug: build failure caused by "arista" patches 2025-05-02 #22534

Closed

bingwang-ms mentioned this pull request May 5, 2025

Fix build failures #22538

Merged

r12f added Request for msft-202412 Branch and removed Request for msft-202412 Branch Cherry Pick Conflict_msft-202412 labels May 6, 2025

mssonicbld added the Cherry Pick Conflict_msft-202412 label May 6, 2025

r12f mentioned this pull request May 6, 2025

Add QoS settings for Arista-7060X6-16PE-384C-O128S2 Azure/sonic-buildimage-msft#1081

Merged

10 tasks

r12f added Approved for msft-202412 Branch Included in msft-202412 Branch and removed Cherry Pick Conflict_msft-202412 labels May 9, 2025

mssonicbld added the Cherry Pick Conflict_msft-202412 label May 9, 2025

kperumalbfn mentioned this pull request May 21, 2025

Update TH5-400G initial buffer configs #22336

Closed

11 tasks

r12f added Request for 202505 Branch and removed Cherry Pick Conflict_msft-202412 labels Jul 12, 2025

mssonicbld added the Cherry Pick Conflict_202505 label Jul 12, 2025

yejianquan added the Approved for 202505 Branch label Jul 14, 2025

yejianquan removed Request for 202505 Branch Approved for 202505 Branch Cherry Pick Conflict_202505 labels Jul 14, 2025

Conversation

rick-arista commented Apr 24, 2025

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented Apr 24, 2025

Uh oh!

azure-pipelines bot commented Apr 24, 2025

Uh oh!

mssonicbld commented Apr 24, 2025

Uh oh!

azure-pipelines bot commented Apr 24, 2025

Uh oh!

kperumalbfn commented Apr 28, 2025

Uh oh!

kperumalbfn Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

kperumalbfn Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

r12f left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

r12f left a comment

Choose a reason for hiding this comment

Uh oh!

r12f Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

r12f Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

kperumalbfn Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

rick-arista Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

kperumalbfn commented Apr 29, 2025

Uh oh!

mssonicbld commented Apr 29, 2025

Uh oh!

azure-pipelines bot commented Apr 29, 2025

Uh oh!

kperumalbfn commented Apr 30, 2025

Uh oh!

kperumalbfn commented Apr 30, 2025

Uh oh!

mssonicbld commented Apr 30, 2025

Uh oh!

azure-pipelines bot commented Apr 30, 2025

Uh oh!

mssonicbld commented Apr 30, 2025

Uh oh!

azure-pipelines bot commented Apr 30, 2025

Uh oh!

Uh oh!

kperumalbfn commented May 2, 2025

Uh oh!

r12f commented May 6, 2025

Uh oh!

kperumalbfn commented May 8, 2025

Uh oh!

yejianquan commented Jul 14, 2025

Uh oh!

yejianquan commented Jul 14, 2025

Uh oh!

Reviewers

Assignees

kperumalbfn Apr 28, 2025 •

edited

Loading